[PATCH] D129531: [clang][C++20] P0960R3 and P1975R0: Allow initializing aggregates from a parenthesized list of values

Thu Dec 8 19:56:04 PST 2022

ayzhao added inline comments.

================
Comment at: clang/lib/AST/JSONNodeDumper.cpp:852
     case VarDecl::ListInit: JOS.attribute("init", "list"); break;
+    case VarDecl::ParenListInit:
+      JOS.attribute("init", "paren-list");
----------------
ilya-biryukov wrote:
> ayzhao wrote:
> > ilya-biryukov wrote:
> > > NIT: maybe use the same formatting as other switch cases for constistency?
> > Unfortunately clang-format insists that these be on separate lines.
> Ah, that's unfortunate. I normally just revert the effect of `clang-format` for those lines, but up to you.
> Also fine to keep as is or even format the other lines according to the style guide (it's just 3 more lines, so should not be a big deal).
> 
> 
Yeah, I would definitely prefer to keep the current style. The problem though is that the buildbots run clang format and will fail if the patch isn't formatted correctly.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129531/new/

https://reviews.llvm.org/D129531