[PATCH] D137051: [Clang] Allow additional mathematical symbols in identifiers.

[Tom Honermann via Phabricator via cfe-commits]

tahonermann accepted this revision.
tahonermann added a comment.
This revision is now accepted and ready to land.

This looks great to me. I added a minor comment regarding the grammar of the added diagnostic, but am accepting the review regardless.



================
Comment at: clang/include/clang/Basic/DiagnosticLexKinds.td:129-130
   InGroup<DiagGroup<"unicode-whitespace">>;
 def warn_utf8_symbol_homoglyph : Warning<
   "treating Unicode character <U+%0> as identifier character rather than "
   "as '%1' symbol">, InGroup<DiagGroup<"unicode-homoglyph">>;
----------------
I think this diagnostic should also have an "an" before "identifier" if you wish to take on correcting it as well.


================
Comment at: clang/include/clang/Basic/DiagnosticLexKinds.td:135-137
+def ext_mathematical_notation : ExtWarn<
+  "mathematical notation character <U+%0> in identifier is a Clang extension">,
+  InGroup<DiagGroup<"mathematical-notation-identifier-extension">>;
----------------
The grammar seems slightly off here. I think there should be an "an" before "identifier":
  - "mathematical notation character <U+%0> in an identifier is a Clang extension"
This would be consistent with `err_character_not_allowed_identifier` and `warn_c99_compat_unicode_id`.




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137051/new/

https://reviews.llvm.org/D137051