[PATCH] D139115: [clang][ExtractAPI] Add support for single symbol SGF

Argyrios Kyrtzidis via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 8 13:43:30 PST 2022


akyrtzi added inline comments.


================
Comment at: clang/include/clang-c/Documentation.h:549
 
+typedef struct CXAPISetImpl *CXAPISet;
+
----------------
benlangmuir wrote:
> @dang please document what this type represents.
> 
> @akyrtzi what's the preferred implementation type name for opaque typedef types? I see we have a mix right now:
> * `void *`
> * `CXOpaqueFoo *`
> * `CXFooImpl *`
There's no consistency in libclang APIs 😅 This typedef LGTM.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139115/new/

https://reviews.llvm.org/D139115



More information about the cfe-commits mailing list