[PATCH] D139444: [ZOS] Convert tests to check 'target={{.*}}-zos'

[Paul Robinson via Phabricator via cfe-commits]

probinson added a comment.

In D139444#3978189 <https://reviews.llvm.org/D139444#3978189>, @uweigand wrote:

> In D139444#3975182 <https://reviews.llvm.org/D139444#3975182>, @probinson wrote:
>
>> The changes in this patch assume that there aren't any possible suffixes after the `-zos` part of the triple (no version numbers, like you might find with darwin or macos, and nothing like `-elf` or `-eabi` like some targets have).  If there are suffixes, I'll happily revise to put `{{.*}}` after everything.
>
> I think for consistency with other targets, and to be safe for future extensions of the target triple, it would be better to add the `{{.*}}`

Okay.

> [for encoding.ll] To express that restriction on the *host* system, you should be using a `REQUIRES: system-zos` line.   However, it looks like this capability is not actually currently implemented - you'll have to add it to the code in `utils/lit/lit/llvm/config.py` here:
>
>   [...]
>           elif platform.system() == 'NetBSD':
>               features.add('system-netbsd')
>           elif platform.system() == 'AIX':
>               features.add('system-aix')
>           elif platform.system() == 'SunOS':
>               features.add('system-solaris')
>
> (Note that you probably still should add the `-mtriple` because the test case requires *both* running on a z/OS host *and* compiling for the z/OS target.)

If you can tell me the `platform.system()` value to look for to detect z/OS, I can do that.  Probably as a separate patch, as it would be going beyond the mechanical replacement that I'm doing for everything else.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139444/new/

https://reviews.llvm.org/D139444