[PATCH] D139629: clang: Stop emitting "strictfp"

Thu Dec 8 10:22:13 PST 2022

arsenm added a comment.

In D139629#3982052 <https://reviews.llvm.org/D139629#3982052>, @arsenm wrote:

> In D139629#3981991 <https://reviews.llvm.org/D139629#3981991>, @zahiraam wrote:
>
>> Can you please be more verbose in your summary? This change is related to the use of -ffp-exception-behavior=strict right? 
>> This attribute is set here https://github.com/llvm/llvm-project/blob/main/clang/lib/CodeGen/CodeGenFunction.cpp#L987 but under a condition. Is that condition always satisfied when the attribute needs to be set?
>
> I don't know if there are other cases that misses; if so it's broken anyway. Nothing reads this string formed version

It's coming from the FunctionDecl and the other case is broader. Only question would be of reachability

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139629/new/

https://reviews.llvm.org/D139629