[PATCH] D139450: Warn about unsupported ibmlongdouble

[Nikita Popov via Phabricator via cfe-commits]

nikic added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/PPCLinux.cpp:74
+    const Driver &D,
+    const llvm::opt::ArgList &Args) const {
+  if (Args.hasArg(options::OPT_nostdlib, options::OPT_nostdlibxx))
----------------
I don't think this formatting is right. You may find clang/tools/clang-format/clang-format-diff.py helpful.

I use this script locally:
```
#!/bin/sh
git diff -U ${1:-HEAD} | clang/tools/clang-format/clang-format-diff.py -p1
```
And then do something like `./clang_format_diff.sh | patch -p0` after checking that it did not reformat too much.


================
Comment at: clang/test/Driver/lit.local.cfg:25
+
+if config.ppc_linux_default_ieeelongdouble == "ON":
+  config.available_features.add('ppc_linux_default_ieeelongdouble')
----------------
I believe this isn't robust, because ON is not the only possible value. Instead, you'll want to canonicalize the variable: https://github.com/llvm/llvm-project/blob/03e6d9d9d1d48e43f3efc35eb75369b90d4510d5/clang/test/CMakeLists.txt#L4


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139450/new/

https://reviews.llvm.org/D139450