[PATCH] D139197: [clang-tidy] Do not warn about redundant static in misc-use-anonymous-namespace

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Dec 7 09:51:48 PST 2022


aaron.ballman added a comment.

In D139197#3978761 <https://reviews.llvm.org/D139197#3978761>, @carlosgalvezp wrote:

> In D139197#3978488 <https://reviews.llvm.org/D139197#3978488>, @aaron.ballman wrote:
>
>> LGTM, though please add a release note describing the change
>
> The original check is just a few days old. It didn't exist in the previous release. Should I still add a comment about this change?

Oh, I hadn't realized the original check was part of this release. No need for a release note in this case.

In D139197#3978771 <https://reviews.llvm.org/D139197#3978771>, @carlosgalvezp wrote:

> PS thanks a lot for the review! :)

Happy to help where I can!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139197/new/

https://reviews.llvm.org/D139197



More information about the cfe-commits mailing list