[PATCH] D128223: [clang] Cached linkage assertion for static locals of static function
David Tenty via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Dec 7 07:22:16 PST 2022
daltenty accepted this revision.
daltenty added a comment.
New revision LGTM, VisibleNoLinkage is typical reserved for types from inline functions so it doesn't seem sensible to return. Looking at the C++ standard, I'm not even convinced this is guaranteed to be the same object if the function doesn't have external linkage, so I think the guard is sensible.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128223/new/
https://reviews.llvm.org/D128223
More information about the cfe-commits
mailing list