[PATCH] D139154: [clang-doc] Add template support

[Paul Kirth via Phabricator via cfe-commits]

paulkirth added inline comments.


================
Comment at: clang-tools-extra/clang-doc/Representation.h:205
+
+  // The literal contents of the code for that specifies this template parameter
+  // for this declaration. Typical values will be "class T" and
----------------



================
Comment at: clang-tools-extra/clang-doc/Representation.h:119-123
+  // This variant (that takes no qualified name parameter) uses the Name as the
+  // QualName (very useful in unit tests to reduce verbosity). This can't use
+  // the empty string as a default because the global namespace uses
+  // "GlobalNamespace" as the name, but should have an empty QualName
+  // (corresponding to the name in code).
----------------
brettw wrote:
> paulkirth wrote:
> > Does this imply that its illegal to use `""` as the name with this constructor? if so, it probably requires at least an assert.
> No, I meant something else, clarified.
Ah, I see now. Thank you.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139154/new/

https://reviews.llvm.org/D139154