[PATCH] D138514: Sema: diagnose PMFs passed through registers to inline assembly

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman added a comment.

Generally LGTM but I'd appreciate a second pass by @rnk in case I've missed something.



================
Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8845-8846
 let CategoryName = "Inline Assembly Issue" in {
+  def err_asm_pmf_in_input
+    : Error<"cannot pass pointer-to-member through a register on this ABI">;
   def err_asm_invalid_lvalue_in_output : Error<"invalid lvalue in asm output">;
----------------
aaron.ballman wrote:
> No idea why Phab won't let me suggest this as an edit, but:
> ```
>   def err_asm_pmf_in_input : Error<
>     "cannot pass pointer-to-member through a register on this ABI">;
> ```
Slight formatting and wording tweaks:
```
  def err_asm_pmf_through_constraint_not_permitted : Error
    "cannot pass a pointer-to-member through a register-constrained inline "
    "assembly parameter">;
```


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138514/new/

https://reviews.llvm.org/D138514