[PATCH] D139436: [C2x] Relaxing requirements for va_start

Erich Keane via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Dec 6 09:28:42 PST 2022


erichkeane added inline comments.


================
Comment at: clang/lib/Sema/SemaChecking.cpp:7230
+      Val && LangOpts.C2x && *Val == 0)
+    return false;
 
----------------
I see below that we still set the return type of hte call to Void.  Do we wnat to keep that line, or at least, move it to the top of this function?


================
Comment at: clang/test/C/C2x/n2975.c:49
+
+void foo(int a...); // expected-error {{C requires a comma prior to the ellipsis in a variadic function type}}
----------------
.  


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139436/new/

https://reviews.llvm.org/D139436



More information about the cfe-commits mailing list