[PATCH] D139436: [C2x] Relaxing requirements for va_start

Corentin Jabot via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Dec 6 08:48:45 PST 2022


cor3ntin added inline comments.


================
Comment at: clang/lib/Headers/stdarg.h:30
+/* C2x does not require the second parameter for va_start. */
+#define va_start(ap, ...) __builtin_va_start(ap, 0)
+#else
----------------
Yeah, i really think there should be some king of diagnostic here.
Maybe `__builtin_va_start` could take an arbitrary number of arguments and diagnose for more that 2 args or if the second arg is not valid?
is it a matter of being compatible with gcc? do we need to?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139436/new/

https://reviews.llvm.org/D139436



More information about the cfe-commits mailing list