[PATCH] D138807: [RISCV] Support vector crypto extension ISA string and assembly

[Craig Topper via Phabricator via cfe-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Support/RISCVISAInfo.cpp:827
+    {{"zvkb"}, {ImpliedExtsZve64x}},
+    {{"zvkg"}, {ImpliedExtsZve32x}},
+    {{"zvknha"}, {ImpliedExtsZve32x}},
----------------
ego wrote:
> What is the reasoning between 32 vs 64 for those sub-extensions?
> I do not think that extensions using 64bxN element groups are restricted to rv64.
> 
> No matter what the end result is, I would welcome some comments explaining the encoded semantics.
The 32 and 64 refer to the ELEN. Zknhb requires SEW=64 so ELEN must be 64


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138807/new/

https://reviews.llvm.org/D138807