[clang] 8e7994b - Revert "[Driver][test] Fix test by creating empty archive instead of empty file"

Nico Weber via cfe-commits cfe-commits at lists.llvm.org
Tue Dec 6 07:23:20 PST 2022


Author: Nico Weber
Date: 2022-12-06T10:22:47-05:00
New Revision: 8e7994b9b513497589d4bf911f061378f517fb16

URL: https://github.com/llvm/llvm-project/commit/8e7994b9b513497589d4bf911f061378f517fb16
DIFF: https://github.com/llvm/llvm-project/commit/8e7994b9b513497589d4bf911f061378f517fb16.diff

LOG: Revert "[Driver][test] Fix test by creating empty archive instead of empty file"

This reverts commit 6b992bcce0c5a86f57c83dd8d0ac9e63bcfc5521.
Test fails on macOS where ar doesn't want to create empty archives,
see https://reviews.llvm.org/D137275#3974489

Added: 
    

Modified: 
    clang/test/Driver/hip-link-bc-to-bc.hip

Removed: 
    


################################################################################
diff  --git a/clang/test/Driver/hip-link-bc-to-bc.hip b/clang/test/Driver/hip-link-bc-to-bc.hip
index ac6dcf494224..972822b5260c 100644
--- a/clang/test/Driver/hip-link-bc-to-bc.hip
+++ b/clang/test/Driver/hip-link-bc-to-bc.hip
@@ -1,4 +1,6 @@
 // REQUIRES: x86-registered-target, amdgpu-registered-target
+// See issue #58711
+// XFAIL: *
 
 // Check that clang unbundles the two bitcodes and links via llvm-link
 // RUN: rm -rf %t && mkdir %t
@@ -19,7 +21,7 @@
 // BITCODE: "{{.*}}llvm-link" "-o" "bundle1-hip-amdgcn-amd-amdhsa-gfx906.bc" "[[B1DEV2]]" "[[B2DEV2]]"
 
 // Check that clang unbundles the bitcode and archive and links via llvm-link
-// RUN: ar rc %t/libhipbundle.a
+// RUN: touch %t/libhipbundle.a
 // RUN: touch %t/bundle.bc
 
 // RUN: %clang -### --target=x86_64-unknown-linux-gnu --offload-arch=gfx906 --hip-link \


        


More information about the cfe-commits mailing list