[PATCH] D128457: [clangd] Add new IncludeType to IncludeHeaderWithReferences

Kadir Cetinkaya via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Dec 6 06:47:02 PST 2022


kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.

thanks, lgtm!



================
Comment at: clang/unittests/Tooling/HeaderAnalysisTest.cpp:69
+  #include "foo.h"
+    #import "NSFoo.h"
+
----------------
indentation


================
Comment at: clang/unittests/Tooling/HeaderAnalysisTest.cpp:69
+  #include "foo.h"
+    #import "NSFoo.h"
+
----------------
kadircet wrote:
> indentation
i think another important positive test case is, having it after some non PP code blocks (e.g. put it after main)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128457/new/

https://reviews.llvm.org/D128457



More information about the cfe-commits mailing list