[PATCH] D138200: [include-cleaner] Make use of locateSymbol in WalkUsed

Kadir Cetinkaya via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Dec 6 06:01:18 PST 2022


kadircet marked 2 inline comments as done.
kadircet added inline comments.


================
Comment at: clang-tools-extra/include-cleaner/test/multiple-providers.cpp:1
+// RUN: clang-include-cleaner --print=changes %s -- -I %S/Inputs | FileCheck \
+// RUN: --allow-empty %s
----------------
sammccall wrote:
> nit: splitting RUN lines over lines makes copy/pasting/debugging lit tests harder and ends up being net-negative IMO. I've added a `.clang-format` file so that >80 col lines won't get split
i also have some extra enforcement by my editor for line breaks :P. i didn't know copy pasting run lines were a workflow (because they usually have place holders one needs to change afterwards), i've always used the command line printed with the failing test. makes sense to keep it in a single line for people with such a workflow though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138200/new/

https://reviews.llvm.org/D138200



More information about the cfe-commits mailing list