[PATCH] D136594: [clangd] Add support for semantic token type "operator"

Christian Kandeler via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Dec 6 03:39:51 PST 2022


ckandeler added a comment.

In D136594#3973812 <https://reviews.llvm.org/D136594#3973812>, @sammccall wrote:

> For my part, I still need to understand why we want the `builtin`/`UserModified` modifier. (The `operator` highlight kind seems obvious to me).

We make this distinction in our client. The reasoning is explained here: https://codereview.qt-project.org/c/qt-creator/qt-creator/+/220587
I think Nathan made the same point earlier, i.e. it's helpful to see that an operator is (potentially) overloaded and you could follow the symbol.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136594/new/

https://reviews.llvm.org/D136594



More information about the cfe-commits mailing list