[PATCH] D139274: Store OptTable::Info::Name as a StringRef

[Nikita Popov via Phabricator via cfe-commits]

nikic added a comment.

Build failure in pre-merge checks:

  FAILED: lib/Option/CMakeFiles/LLVMOption.dir/OptTable.cpp.o
  CCACHE_CPP2=yes CCACHE_HASHDIR=yes /usr/bin/ccache /usr/bin/clang++ -DBUILD_EXAMPLES -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/var/lib/buildkite-agent/builds/llvm-project/build/lib/Option -I/var/lib/buildkite-agent/builds/llvm-project/llvm/lib/Option -I/var/lib/buildkite-agent/builds/llvm-project/build/include -I/var/lib/buildkite-agent/builds/llvm-project/llvm/include -gmlt -fPIC -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG  -fno-exceptions -fno-rtti -UNDEBUG -std=c++17 -MD -MT lib/Option/CMakeFiles/LLVMOption.dir/OptTable.cpp.o -MF lib/Option/CMakeFiles/LLVMOption.dir/OptTable.cpp.o.d -o lib/Option/CMakeFiles/LLVMOption.dir/OptTable.cpp.o -c /var/lib/buildkite-agent/builds/llvm-project/llvm/lib/Option/OptTable.cpp
  /var/lib/buildkite-agent/builds/llvm-project/llvm/lib/Option/OptTable.cpp:70:15: error: no matching function for call to 'StrCmpOptionName'
    if (int N = StrCmpOptionName(A.Name, B.Name))
                ^~~~~~~~~~~~~~~~
  /var/lib/buildkite-agent/builds/llvm-project/llvm/lib/Option/OptTable.cpp:60:12: note: candidate function not viable: no known conversion from 'const llvm::StringRef' to 'const char *' for 1st argument
  static int StrCmpOptionName(const char *A, const char *B) {
             ^
  1 error generated.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139274/new/

https://reviews.llvm.org/D139274