[PATCH] D138792: [AArch64] Improve TargetParser API

Tomas Matheson via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Dec 4 12:52:52 PST 2022


tmatheson added a comment.

Yes I will look into it and address the other comments when I have more time tomorrow or later this week. However I'm starting to think that the comparison by address is too easy to subtly break, and not immediately obvious to debug, and is therefore not worth it in this case. The performance of the comparison is not especially critical here afaik.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138792/new/

https://reviews.llvm.org/D138792



More information about the cfe-commits mailing list