[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

[Michael Buch via Phabricator via cfe-commits]

Michael137 added a comment.

In D127284#3969308 <https://reviews.llvm.org/D127284#3969308>, @v.g.vassilev wrote:

> In D127284#3969249 <https://reviews.llvm.org/D127284#3969249>, @v.g.vassilev wrote:
>
>> In D127284#3969225 <https://reviews.llvm.org/D127284#3969225>, @Michael137 wrote:
>>
>>> FYI, looks like this broke the LLDB incremental buildbot. Following tests started failing:
>>>
>>>   lldb-api.commands/expression/argument_passing_restrictions.TestArgumentPassingRestrictions.py
>>>   lldb-api.commands/expression/deleting-implicit-copy-constructor.TestDeletingImplicitCopyConstructor.py
>>>   lldb-api.commands/expression/diagnostics.TestExprDiagnostics.py
>>>   lldb-api.commands/expression/import-std-module/array.TestArrayFromStdModule.py
>>>   lldb-api.commands/expression/import-std-module/module-build-errors.TestStdModuleBuildErrors.py
>>>   lldb-api.commands/expression/rdar44436068.Test128BitsInteger.py
>>>   lldb-api.commands/expression/weak_symbols.TestWeakSymbols.py
>>>   lldb-api.commands/target/dump-pcm-info.TestDumpPCMInfo.py
>>>   lldb-api.functionalities/data-formatter/compactvectors.TestCompactVectors.py
>>>   lldb-api.functionalities/tail_call_frames/cross_object.TestCrossObjectTailCalls.py
>>>   lldb-api.functionalities/target_var/no_vars.TestTargetVarNoVars.py
>>>   lldb-api.lang/c/modules.TestCModules.py
>>>   lldb-api.lang/cpp/accelerator-table.TestCPPAccelerator.py
>>>   lldb-api.lang/cpp/modules-import.TestCXXModulesImport.py
>>>   lldb-api.lang/objc/modules.TestObjCModules.py
>>>   lldb-api.lang/objc/modules-auto-import.TestModulesAutoImport.py
>>>   lldb-api.lang/objc/modules-cache.TestClangModulesCache.py
>>>   lldb-api.lang/objc/modules-compile-error.TestModulesCompileError.py
>>>   lldb-api.lang/objc/modules-incomplete.TestIncompleteModules.py
>>>   lldb-api.lang/objc/modules-inline-functions.TestModulesInlineFunctions.py
>>>   lldb-api.lang/objc/modules-non-objc-target.TestObjCModulesNonObjCTarget.py
>>>   lldb-api.lang/objc/modules-objc-property.TestModulesObjCProperty.py
>>>   lldb-api.tools/lldb-server.TestLldbGdbServer.py
>>>
>>> https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/48872/
>>> https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/48873/
>>>
>>> Last successful build: https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/48871/
>>
>> Hi @Michael137, I cannot reproduce these failures on unix. Is there some special way I need to compile. I will try reproducing them on OSX. Did you have time to debug where the tests fail?
>
> I cannot reproduce this on osx either.

Hmmm how are you running the tests? It reproduces pretty consistently with the patch and doesn't without it. I just run `ninja check-lldb-api`

Let me try with a clean build


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127284/new/

https://reviews.llvm.org/D127284