[PATCH] D138358: [clang-format] Match all block braces

Sat Dec 3 18:47:56 PST 2022

owenpan added a comment.

In D138358#3968759 <https://reviews.llvm.org/D138358#3968759>, @HazardyKnusperkeks wrote:

> In D138358#3968610 <https://reviews.llvm.org/D138358#3968610>, @owenpan wrote:
>
>> Please see D139257 <https://reviews.llvm.org/D139257> for a different approach.
>
> All my hard work... *sniff*.

I can definitely sympathise as I've abandoned a lot patches, the vast majority of which were never even submitted.

I had spent a lot of time playing with your patch but couldn't decide if it would break removing optional braces. Because I liked your idea of linking block braces early in the parser instead but wanted to avoid changing the signature of `parseBlock()` in doing so, I came up with a different approach. It was only then that I found the litmus test <https://reviews.llvm.org/D138358#3968592>.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138358/new/

https://reviews.llvm.org/D138358