[PATCH] D139258: Remove the enableIncrementalProcesing logic in favor of -fincremental-extensions

Vassil Vassilev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Dec 3 10:30:40 PST 2022


v.g.vassilev created this revision.
v.g.vassilev added reviewers: aaron.ballman, rsmith, shafik.
Herald added a subscriber: kristof.beyls.
Herald added a project: All.
v.g.vassilev requested review of this revision.

As we have discussed in https://reviews.llvm.org/D127284 we would like to phase out `enableIncrementalProcesing` and use a better integrated option.

https://reviews.llvm.org/D127284 introduces a `LangOpt` called `IncrementalExtensions`, however, we also have a `TU_Incremental` kind. I am not entirely sure when we should use that because generally most of our actions (even if we pass `-fincremental-extensions`) we still get `TU_Complete`.

@aaron.ballman, @rsmith, do you have an idea how to harmonize this?


https://reviews.llvm.org/D139258

Files:
  clang/include/clang/Lex/Preprocessor.h
  clang/lib/Interpreter/IncrementalParser.cpp
  clang/lib/Lex/PPLexerChange.cpp
  clang/lib/Parse/ParseDecl.cpp
  clang/lib/Parse/Parser.cpp
  clang/lib/Sema/Sema.cpp
  clang/unittests/Frontend/FrontendActionTest.cpp
  lldb/source/Plugins/ExpressionParser/Clang/ClangModulesDeclVendor.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D139258.479849.patch
Type: text/x-patch
Size: 7781 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20221203/837eb30b/attachment.bin>


More information about the cfe-commits mailing list