[PATCH] D138939: [WIP][clang] adds a way to provide user-oriented reasons
Thorsten via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Dec 2 12:27:47 PST 2022
tschuett added a comment.
I do not ask you to do anything! I just noticed that you add a lot of `FormatXXXDiagnostic` functions. An alternativ design is to have one `FormatDiagnostic` function with a mode parameter. Then you can decide whether to print legacy or user-oriented reasons.
If next year you invent another diagnostic, you can extend the enum and the `FormatDiagnostic` function.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D138939/new/
https://reviews.llvm.org/D138939
More information about the cfe-commits
mailing list