[PATCH] D138792: [AArch64] Improve TargetParser API

Tomas Matheson via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Dec 2 11:33:40 PST 2022


tmatheson added a comment.

In D138792#3966920 <https://reviews.llvm.org/D138792#3966920>, @Hahnfeld wrote:

> Hi, I bisected this change to lead to a couple of test failures when building with `LLVM_LINK_LLVM_DYLIB`. In the past, this had to do with global variable initialization order, but nothing immediately jumps to my eye in this patch. Is `AARCH64_ARCH` used to define global variables?

Hi, yes this change introduces a bunch of `inline constexpr` global variables in `AArch64TargetParser.h`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138792/new/

https://reviews.llvm.org/D138792



More information about the cfe-commits mailing list