[PATCH] D138157: Make -fsanitize=scudo use scudo_standalone. Delete check-scudo.

Mitch Phillips via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Dec 2 11:24:39 PST 2022


hctim updated this revision to Diff 479693.
hctim added a comment.

Lots of places in scudo_standalone depend on GWP-ASan, and it seems far more reasonable to make COMPILER_RT_HAS_GWP_ASAN mean "is GWP-ASan actually going to be built", rather than checking three variables in all the places.

Give the same treatment to COMPILER_RT_HAS_SCUDO_STANDALONE.

This should fix the reviewer problems that were identified:

1. scudo_standalone's cmake rules don't get generated when COMPILER_RT_BUILD_SANITIZERS=Off or COMPILER_RT_SANITIZERS_TO_BUILD does not contain scudo_standalone.
2. check-scudo_standalone's cmake rules don't get generated when COMPILER_RT_INCLUDE_TESTS=Off.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138157/new/

https://reviews.llvm.org/D138157

Files:
  clang/lib/Driver/ToolChains/CommonArgs.cpp
  clang/test/Driver/fuchsia.c
  clang/test/Driver/sanitizer-ld.c
  compiler-rt/cmake/config-ix.cmake
  compiler-rt/lib/CMakeLists.txt
  compiler-rt/test/CMakeLists.txt
  compiler-rt/test/scudo/CMakeLists.txt
  compiler-rt/test/scudo/standalone/CMakeLists.txt
  llvm/docs/GwpAsan.rst

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D138157.479693.patch
Type: text/x-patch
Size: 13831 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20221202/d6ba69f3/attachment-0001.bin>


More information about the cfe-commits mailing list