[PATCH] D139197: Do not warn about redundant static in misc-use-anonymous-namespace

Carlos Galvez via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Dec 2 07:22:04 PST 2022


carlosgalvezp added a comment.

Ah, then it has the exact same functionality! My idea for readability-redundant-static was to warn about:

- static in anonymous namespace
- static const/constexpr at global scope (since const gives implicit internal linkage in C++).

I will see what I can do about that.

This shouldn't be a blocker for this patch though, it's just removing functionality that belongs in another check. As said, the check is 1 day old so it's unlikely anyone is relying on it yet :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139197/new/

https://reviews.llvm.org/D139197



More information about the cfe-commits mailing list