[PATCH] D139170: [X86][clang] Lift _BitInt() supported max width.

Matthias Gehre via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Dec 2 00:23:41 PST 2022


mgehre-amd added a comment.

In D139170#3965850 <https://reviews.llvm.org/D139170#3965850>, @FreddyYe wrote:

> In D139170#3965814 <https://reviews.llvm.org/D139170#3965814>, @mgehre-amd wrote:
>
>> Do other targets not support > 128 bit integers, or is this PR only the first conservative step of lifting the limit?
>
> I temporary only enabled > 128 bit FP conversion for X86 in https://reviews.llvm.org/D137241, since I highly relied on end-to-end tests to implement that pass and I don't have other targets' environment to verify. So same to this patch, I only lift the limit for X86. Hope other targets will follow us to enable for themselves. WDYT?

A right, I was confused because I saw llvm/test/CodeGen/AArch64/O0-pipeline.ll running the new pass on AArch64, but actually it doesn't do anything unless it's enabled in llvm/lib/Target/*/*ISelLowering.cpp. Got it, thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139170/new/

https://reviews.llvm.org/D139170



More information about the cfe-commits mailing list