[PATCH] D138296: [clang] Avoid duplicating ProgramAddressSpace in TargetInfo. NFCI

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 1 10:29:53 PST 2022


rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.

I think this is fine.  Most of the patch is changing calls to `getTargetAddressSpace` to be internal to IRGen, which, as mentioned, I think is the right move.

I do think that if we're going to support multiple program address spaces (which seems to be a goal) that we'll eventually want an AST-level concept of the default program address space, but perpetuating the use of target ASes at the AST level isn't the right way to approach that, so this is still the right first step.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138296/new/

https://reviews.llvm.org/D138296



More information about the cfe-commits mailing list