[PATCH] D139090: [clang] Add test for CWG360

Erich Keane via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 1 07:25:09 PST 2022


erichkeane added inline comments.


================
Comment at: clang/test/CXX/drs/dr3xx.cpp:908
+public:
+  using A::baz; // #dr360-baz-using-decl
+};
----------------
aaron.ballman wrote:
> Endill wrote:
> > erichkeane wrote:
> > > This bookmark isn't necessary, so no reason to have it.  But thank you for using these!
> > Nice catch, thank you!
> > Seems like I should've waited a bit more before committing.
> Good catch Erich!
> 
> Feel free to fix the comment up with an NFC commit (you don't need anyone to review it because there's no functional change).
Don't worry about it, this is a trivial issue I just saw while scrolling/admiring the bookmarks :D  a follow-up review-after-commit patch would be fine here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139090/new/

https://reviews.llvm.org/D139090



More information about the cfe-commits mailing list