[PATCH] D127812: [AArch64] FMV support and necessary target features dependencies.

Thu Dec 1 05:49:16 PST 2022

dmgreen added inline comments.

================
Comment at: llvm/include/llvm/Support/AArch64TargetParser.def:115
+AARCH64_ARCH_EXT_NAME("rdm",           AArch64::AEK_RDM,         "+rdm",          "-rdm",         \
+RDM,          "+rdm,+fp-armv8,+neon,+jsconv,+complxnum",                                70)
+AARCH64_ARCH_EXT_NAME("crypto",        AArch64::AEK_CRYPTO,      "+crypto",       "-crypto",      \
----------------
ilinpv wrote:
> dmgreen wrote:
> > Should RDM be dependant on +jsconv,+complxnum?
> I suppose RDM implies simd (+neon) which implies +jsconv,+complxnum
jsconv and complxnum are 8.3 features, are they not? Or do they somehow mean something different here? It would seem strange for neon to depend on them.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127812/new/

https://reviews.llvm.org/D127812