[PATCH] D139093: [include-cleaner] Use RAV instead of ASTMatchers in LocateSymbolTest
Sam McCall via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Dec 1 03:23:47 PST 2022
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
================
Comment at: clang-tools-extra/include-cleaner/unittests/LocateSymbolTest.cpp:60
+ return true;
+ Out = ND;
+ return false;
----------------
you might want to EXPECT_EQ(Out, nullptr) first to ensure only a single match
(A single match for a name may not generalize well, but the matching would have to be made more specific regardless in that case)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139093/new/
https://reviews.llvm.org/D139093
More information about the cfe-commits
mailing list