[PATCH] D127812: [AArch64] FMV support and necessary target features dependencies.

Pavel Iliin via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 1 02:28:41 PST 2022


ilinpv marked an inline comment as done.
ilinpv added inline comments.


================
Comment at: compiler-rt/lib/builtins/cpu_model.c:1311
+  // CPU features already initialized.
+  if (__aarch64_cpu_features.features)
+    return;
----------------
danielkiss wrote:
> I'd add a init value for the declaration to be sure it is properly initialised. 
I reply on __aarch64_cpu_features as global is guaranteed to be initialised to 0.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127812/new/

https://reviews.llvm.org/D127812



More information about the cfe-commits mailing list