[PATCH] D139025: [NFC][RISCV] Extract utility to calculate value through MajorVersion and MinorVersion
Yueh-Ting (eop) Chen via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Nov 30 23:19:08 PST 2022
eopXD marked an inline comment as done.
eopXD added inline comments.
================
Comment at: llvm/include/llvm/Support/RISCVISAInfo.h:25
+ unsigned getVersionValue() {
+ return MajorVersion * 1000000 + MinorVersion * 1000;
+ }
----------------
asb wrote:
> Would this be better as `return getVersionValue(MajorVersion, MinorVersion);` in order to maximise logic reuse?
Reuse no longer needed here.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139025/new/
https://reviews.llvm.org/D139025
More information about the cfe-commits
mailing list