[PATCH] D138901: [clang] Propely handle tests for open DRs in make_cxx_dr_status

H. Vetinari via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 30 17:38:31 PST 2022


h-vetinari added a comment.

I'd also use newlines more liberally since the two-space indentation is pretty dense already.



================
Comment at: clang/www/make_cxx_dr_status:190-191
+             % (dr.issue, unresolved_status, dr.status)
+    if not avail.startswith('Sup') and not avail.startswith('Dup'):
+      count[avail] = count.get(avail, 0) + 1
   else:
----------------
These two lines are the same with the end of the else-branch, i.e. they could both be lifted out of the if-clause and unified at the end.


================
Comment at: clang/www/make_cxx_dr_status:198-199
+           % (dr.issue, unresolved_status)
     if not avail.startswith('Sup') and not avail.startswith('Dup'):
       count[avail] = count.get(avail, 0) + 1
 
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138901/new/

https://reviews.llvm.org/D138901



More information about the cfe-commits mailing list