[PATCH] D138930: [RISCV] Add macro to imply compiler availability on RISC-V Vector intrinsics version

Yueh-Ting (eop) Chen via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 30 09:08:16 PST 2022


eopXD marked 2 inline comments as done.
eopXD added inline comments.


================
Comment at: clang/lib/Basic/Targets/RISCV.cpp:195
     Builder.defineMacro("__riscv_vector");
+    // Currently we support the v0.10 RISC-V V intrinsics
+    unsigned Version = (0 * 1000000) + (10 * 1000);
----------------
jrtc27 wrote:
> eopXD wrote:
> > asb wrote:
> > > Nit: comment should end with full stop.
> > Sorry I just landed the commit and missed this comment. May I ask what do yo mean by full stop here? Do you mean a period?
> Full stop is British English for what is period in US English, yes
Done in https://reviews.llvm.org/rGd8a27ac0e27f


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138930/new/

https://reviews.llvm.org/D138930



More information about the cfe-commits mailing list