[PATCH] D139014: [include-cleaner] Move RecordedPP::RecordedIncludes -> Includes in Types.h. NFC

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 30 07:34:03 PST 2022


sammccall created this revision.
sammccall added a reviewer: kadircet.
Herald added a project: All.
sammccall requested review of this revision.
Herald added a project: clang-tools-extra.
Herald added a subscriber: cfe-commits.

Requiring everything that wants to match Includes to depend on Record is weird.
This isn't lightweight enough that it feels perfect in Types, could be its own
header instead. But pragmatically it doesn't add bad deps, and is widely used.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D139014

Files:
  clang-tools-extra/include-cleaner/include/clang-include-cleaner/Record.h
  clang-tools-extra/include-cleaner/include/clang-include-cleaner/Types.h
  clang-tools-extra/include-cleaner/lib/AnalysisInternal.h
  clang-tools-extra/include-cleaner/lib/HTMLReport.cpp
  clang-tools-extra/include-cleaner/lib/Record.cpp
  clang-tools-extra/include-cleaner/lib/Types.cpp
  clang-tools-extra/include-cleaner/unittests/CMakeLists.txt
  clang-tools-extra/include-cleaner/unittests/RecordTest.cpp
  clang-tools-extra/include-cleaner/unittests/TypesTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D139014.478949.patch
Type: text/x-patch
Size: 13714 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20221130/d006316c/attachment-0001.bin>


More information about the cfe-commits mailing list