[PATCH] D138821: [include-cleaner] Remove filtering from UsingDecl visit.

[Haojian Wu via Phabricator via cfe-commits]

hokein added inline comments.


================
Comment at: clang-tools-extra/include-cleaner/unittests/WalkASTTest.cpp:130
 TEST(WalkAST, Using) {
-  // Make sure we ignore unused overloads.
+  // We should report unused overloads as ambiguous.
   testWalk(R"cpp(
----------------
nit: update the comment.


================
Comment at: clang-tools-extra/include-cleaner/unittests/WalkASTTest.cpp:140
     })cpp",
            "// c++-header\n using ns::^x;");
+  testWalk(R"cpp(
----------------
I think the `c++-header` is not needed, we can even remove the special `c++-header` logic in `testWalk`.


================
Comment at: clang-tools-extra/include-cleaner/unittests/WalkASTTest.cpp:148
+
+  // We should report references to templates as ambiguous.
+  testWalk(R"cpp(
----------------
nit: the comment is stale, we report all refs as explicit now. I think we can just remove this case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138821/new/

https://reviews.llvm.org/D138821