[PATCH] D137340: [clang-tidy] Add misc-use-anonymous-namespace check
Carlos Galvez via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Nov 30 05:55:14 PST 2022
carlosgalvezp marked an inline comment as done.
carlosgalvezp added inline comments.
================
Comment at: clang-tools-extra/docs/clang-tidy/checks/misc/use-anonymous-namespace.rst:7-9
+that could instead be moved into an anonymous namespace. It also detects
+instances moved to an anonymous namespace that still keep the redundant
+``static``.
----------------
bigdavedev wrote:
> Would we want this to be a fix as well? Removing the `static` keyword automatically would be nice.
Would make sense to fix, but unfortunately with my limited AST knowledge I don't know how to get the location of the `static` token to apply a removal. So unless someone wants to help out with that it will have to stay as is for now.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137340/new/
https://reviews.llvm.org/D137340
More information about the cfe-commits
mailing list