[PATCH] D138939: [WIP][clang] adds a way to provide user-oriented reasons

[Emilia Dreamer via Phabricator via cfe-commits]

rymiel added inline comments.


================
Comment at: clang/include/clang/Frontend/DiagnosticRenderer.h:130
   /// \param Message The diagnostic message to emit.
+  /// \param Reason Supplementary information for the message.
   /// \param Ranges The underlined ranges for this code snippet.
----------------
Which parameter is this doxygen comment referring to?


================
Comment at: clang/tools/clang-format/ClangFormat.cpp:397
+  Info.FormatSummary(vec);
+  Info.FormatLegacyReason(vec);
     errs() << "clang-format error:" << vec << "\n";
----------------
I don't think this indent change was intended?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138939/new/

https://reviews.llvm.org/D138939