[PATCH] D138252: [clang][deps] During scanning don't emit warnings-as-errors that are ignored with diagnostic pragmas.

[Volodymyr Sapsai via Phabricator via cfe-commits]

vsapsai added a comment.

Ok, I was able to reproduce the error on macOS by adding `-target x86_64-sie-ps5` to one of commands in "clang/test/ClangScanDeps/Inputs/no-werror.json" (wouldn't mind receiving PS5 DevKit, by the way). The problem is that `Driver::BuildCompilation` overwrites `DiagnosticsEngine::IgnoreAllWarnings` ignoring everything specified in `DiagnosticOptions::IgnoreWarnings`. Thus we still emit the warning despite asking in `DiagnosticOptions` not to. D138970 <https://reviews.llvm.org/D138970> fixes this situation and relies on `DiagnosticOptions` to set diagnostic options.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138252/new/

https://reviews.llvm.org/D138252