[PATCH] D137995: [Flang][Driver] Handle target CPU and features

Usman Nadeem via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 29 17:38:57 PST 2022


mnadeem added a comment.

In D137995#3944145 <https://reviews.llvm.org/D137995#3944145>, @awarzynski wrote:

> Thanks for implementing this!
>
>> Processes target cpu and features in the flang driver. Right now features are only added for AArch64 because I only did basic testing on AArch64 but it should generally work for others as well.
>
> X86 is a very popular target and we have pre-commit CI as well. And X86 buildbots :) Please include X86.
>
> Question: are the option semantics identical that what you get in `clang -cc1`? If yes, could you add a comment in the summary?

Included x86 and added a comment in the summary.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137995/new/

https://reviews.llvm.org/D137995



More information about the cfe-commits mailing list