[PATCH] D138947: [Clang] Remove invalid assert from Sema::BuildCXXTypeConstructExpr

Corentin Jabot via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 29 16:54:33 PST 2022


cor3ntin added inline comments.


================
Comment at: clang/lib/Sema/SemaExprCXX.cpp:1464
-          (Exprs.size() == 1 && isa<InitListExpr>(Exprs[0]))) &&
-         "List initialization must have initializer list as expression.");
   SourceRange FullRange = SourceRange(TyBeginLoc, RParenOrBraceLoc);
----------------
`Exprs.size()  == 1`  should still be true, right? Is it worth keeping? Maybe?
Similarly, is `ListInitialization` the right name here? Maybe `ParsedAsListInitialization` or something?  Or a Fixme?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138947/new/

https://reviews.llvm.org/D138947



More information about the cfe-commits mailing list