[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

Eli Friedman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 29 16:36:13 PST 2022


efriedma added inline comments.


================
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:4822
       Init = Initializer;
+      if (Initializer->isDLLImportDependent())
+        NeedsGlobalCtor = true;
----------------
This check probably needs to be inside tryEmitForInitializer, so other callers of tryEmitForInitializer don't get confused.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137107/new/

https://reviews.llvm.org/D137107



More information about the cfe-commits mailing list