[PATCH] D137020: [clang][AST] Handle variable declaration with unknown typedef in C

Dilshod Urazov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 29 10:58:52 PST 2022


urazoff added inline comments.


================
Comment at: clang/test/Parser/recovery.c:105
+  unknown_t a; // expected-error {{unknown type name 'unknown_t'}}
+  unknown_t *b; // expected-error {{unknown type name 'unknown_t'}}
+  unknown_t const *c; // expected-error {{unknown type name 'unknown_t'}}
----------------
sammccall wrote:
> this diagnostic is worse than the old one (less accurate).
> 
> (I think it's OK to trade off diagnostics quality if it's better on balance, maybe leave a comment?)
Just to mention, this is exact behavior of clang for C++.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137020/new/

https://reviews.llvm.org/D137020



More information about the cfe-commits mailing list