[PATCH] D138861: [Clang] Implement CWG2640 Allow more characters in an n-char sequence

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 29 10:41:24 PST 2022


aaron.ballman added inline comments.


================
Comment at: clang/test/CXX/drs/dr26xx.cpp:41
+#define a z(
+int x = a\N{abc}); // expected-error 2{{'abc' is not a valid Unicode character name}}
+
----------------
Why do we get two errors here?

Also, can you add this case:
```
int y = a\N{LOTUS});
```
to show that we now form an identifier for `a\N{LOTUS}` instead of trying to expand `a` as a macro; we should get a new diagnostic about the stray `)` instead.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138861/new/

https://reviews.llvm.org/D138861



More information about the cfe-commits mailing list