[PATCH] D138392: clang/HIP: Fix broken implementations of __make_mantissa* functions

Jon Chesterfield via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 28 15:47:43 PST 2022


JonChesterfield accepted this revision.
JonChesterfield added a comment.
This revision is now accepted and ready to land.

Patch is obviously fine. Given these are internal functions, perhaps we should annotate them with the non-null attribute and delete the early exit.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138392/new/

https://reviews.llvm.org/D138392



More information about the cfe-commits mailing list