[PATCH] D138870: clang/AMDGPU: Remove flat-address-space from feature map

Matt Arsenault via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 28 14:59:18 PST 2022


arsenm created this revision.
arsenm added reviewers: yaxunl, JonChesterfield, b-sumner, jdoerfert.
Herald added subscribers: kosarev, kerbowa, tpr, dstuttard, jvesely, kzhuravl.
Herald added a project: All.
arsenm requested review of this revision.
Herald added subscribers: sstefan1, wdng.

This was only used for checking if is_shared/is_private were legal,
 which we're not bothering to do anymore.

      

This is apparently visible to more than the target attribute (which
seems to silently ignore unrecognized features), so this has the
potential to break something (i.e. see the OpenMP test change)


https://reviews.llvm.org/D138870

Files:
  clang/lib/Basic/Targets/AMDGPU.cpp
  clang/test/CodeGenOpenCL/amdgpu-features.cl
  clang/test/OpenMP/amdgcn-attributes.cpp
  clang/test/OpenMP/metadirective_device_isa_codegen_amdgcn.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D138870.478387.patch
Type: text/x-patch
Size: 16542 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20221128/0c0ca2d7/attachment-0001.bin>


More information about the cfe-commits mailing list