[PATCH] D138603: [Clang] Implement LWG3823 for __is_aggregate

[Roy Jacobson via Phabricator via cfe-commits]

royjacobson marked an inline comment as done.
royjacobson added inline comments.


================
Comment at: clang/test/SemaCXX/type-traits.cpp:556
   static_assert(__is_aggregate(EmptyArMB), "");
   static_assert(!__is_aggregate(void), "");
   static_assert(!__is_aggregate(const volatile void), "");
----------------
cjdb wrote:
> shafik wrote:
> > Should this be `true` now or am I misunderstanding.
> This should stay false, because the change is only concerned with arrays of incomplete types.
> Should this be `true` now or am I misunderstanding.

If you refer to the 'or cv' part, I think you're mixing up the completeness precondition with the builtin's actual value.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138603/new/

https://reviews.llvm.org/D138603