[PATCH] D138651: [CUDA][HIP] Don't diagnose use for __bf16

Mon Nov 28 14:30:32 PST 2022

yaxunl added a comment.

In D138651#3954179 <https://reviews.llvm.org/D138651#3954179>, @tra wrote:

>> Builds were failing because "__bf16" wasn't allowed on the target.
>
> For CUDA/NVPTX we've solved the issue by implementing storage-only support for NVPTX: https://reviews.llvm.org/D136311
> It's a bit more work, but I think it would be a better fix long-term for AMDGPU, too.

Agree supportting bf16 in backend is a better solution. Limited by resource, overall this patch LGTM.

================
Comment at: clang/test/SemaCUDA/amdgpu-bf16.cu:17
+typedef __bf16 foo __attribute__((__vector_size__(16), __aligned__(16)));
\ No newline at end of file

----------------
missing new line

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138651/new/

https://reviews.llvm.org/D138651