[PATCH] D138859: [ODRHash] Drive attribute hashing through TableGen. NFC intended.

Volodymyr Sapsai via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 28 13:22:45 PST 2022


vsapsai added a comment.

This patch builds on top of D135472 <https://reviews.llvm.org/D135472> and aims to show that hashing attributes with TableGen works fine and doesn't have unexpected problems.

As the next step I plan to hash more attributes. Though there is one question regarding arguments excluded from the hash, for example, deprecation message. My plan for that is to introduce a separate attribute tentatively called `ExcludeFromHashingArguments`. I've decided not to repeat hashable pieces for each attribute but only to exclude a few of them as I expect it provide more signal.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138859/new/

https://reviews.llvm.org/D138859



More information about the cfe-commits mailing list